Yes but I don't want to edit files directly as there are so many nodebb updates that will overwrite changes.
In addition, I never had to edit this file to get the logo working in emails so I'm very hesitant about touching that.

You are just editing it to debug the issue, once you see the correct url there you can revert the change back.

Ok, I can try that.

Making this change worked;
Emailer._defaultPayload = {
url: nconf.get('url'),
site_title: meta.config.title || 'NodeBB',
logo: {
src: "https://my.nodebb.com/assets/uploads/system/site-logo.png",
height: 50,
width: 247,
},
};

I also tried this with no luck.

nodebb> db.objects.find({ _key: "meta/config" }).pretty()
...

nodebb> db.objects.find({ _key: "meta/config" }, { logo: 1, _id: 0 }).pretty()
...

nodebb>

This confirmed that the meta/config document currently does not exist in the database.

db.objects.insertOne({
_key: "meta/config",
logo: "https://my.nodebb.com/assets/uploads/system/site-logo.png"
})

Rebuilt and restarted NodeBB

./nodebb build
./nodebb restart

No change.

The key name is just config not meta/config

Ok but either way, I can't customize this page that will get overwritten so how can I get this to work? More importantly, why is it not working since it worked before the domain name change.

NodeHam regarding the user name change, are you sure it worked? Can you access the user via their new username?

Yes, I can log in and out, post as the renamed user.

NodeHam sounds like a varnish cache issue...

Could be, if I had a cache installed but I don't. I cleared nodebb cache as well but the problem persists. Right now, the only way this works is with the edited file which I'd like to restore.

Does anyone have any other thoughts? It's been using an edited file to solve this and I prefer not to do that and to solve this before there is another nodebb update.

NodeHam this is not related to a remote user account, right? But a local account?

To be safe, what you do mean by remote user account? It's a user on nodebb itself so I suppose that means local.

NodeHam yes, a remote account would be an account on another NodeBB forum, for example, reached via federation.

So you're able to access both user pages? What happens when you type ajaxify.data into the browser dev console on both pages?

Got it, no federation at all, single site on its own.

I'm not terribly concerned about the slug at this point. The email logo was fixed by editing the file and that's what I'm mainly nervous about.

ajaxify.data
{uid: 49, username: 'HelpSupport', userslug: 'helpsupport', email: '[email protected]', email:confirmed: true, …}

NodeHam thanks, and what about at the new url?

Sorry, are we talking about the image or the user now?
The image url is correct but emails do not have that, they have the old url without the edited file.
It's like something got 'stuck' for lack of better word.

NodeHam any chance we can see this site?